PMD Results

The following document contains the results of PMD 7.0.0.

Violations By Priority

Priority 3

webmagic-core - us/codecraft/webmagic/Spider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Status(int)': enum constructors are implicitly private 685

webmagic-core - us/codecraft/webmagic/Task.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getUUID': the method is declared in an interface type 18
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSite': the method is declared in an interface type 25

webmagic-core - us/codecraft/webmagic/downloader/Downloader.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'download': the method is declared in an interface type 24
UnnecessaryModifier Unnecessary modifier 'public' on method 'setThread': the method is declared in an interface type 30

webmagic-core - us/codecraft/webmagic/downloader/HttpUriRequestConverter.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'site'. 41

webmagic-core - us/codecraft/webmagic/pipeline/CollectorPipeline.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCollected': the method is declared in an interface type 19

webmagic-core - us/codecraft/webmagic/pipeline/Pipeline.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'process': the method is declared in an interface type 23

webmagic-core - us/codecraft/webmagic/scheduler/MonitorableScheduler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLeftRequestsCount': the method is declared in an interface type 13
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTotalRequestsCount': the method is declared in an interface type 15

webmagic-core - us/codecraft/webmagic/scheduler/Scheduler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'push': the method is declared in an interface type 23
UnnecessaryModifier Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type 31

webmagic-core - us/codecraft/webmagic/scheduler/component/DuplicateRemover.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isDuplicate': the method is declared in an interface type 20
UnnecessaryModifier Unnecessary modifier 'public' on method 'resetDuplicateCheck': the method is declared in an interface type 26
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTotalRequestsCount': the method is declared in an interface type 33

webmagic-core - us/codecraft/webmagic/selector/ElementSelector.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'select': the method is declared in an interface type 22
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type 30

webmagic-core - us/codecraft/webmagic/selector/Selectable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'xpath': the method is declared in an interface type 19
UnnecessaryModifier Unnecessary modifier 'public' on method '$': the method is declared in an interface type 27
UnnecessaryModifier Unnecessary modifier 'public' on method '$': the method is declared in an interface type 36
UnnecessaryModifier Unnecessary modifier 'public' on method 'css': the method is declared in an interface type 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'css': the method is declared in an interface type 53
UnnecessaryModifier Unnecessary modifier 'public' on method 'links': the method is declared in an interface type 59
UnnecessaryModifier Unnecessary modifier 'public' on method 'regex': the method is declared in an interface type 67
UnnecessaryModifier Unnecessary modifier 'public' on method 'regex': the method is declared in an interface type 76
UnnecessaryModifier Unnecessary modifier 'public' on method 'replace': the method is declared in an interface type 85
UnnecessaryModifier Unnecessary modifier 'public' on method 'toString': the method is declared in an interface type 92
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 99
UnnecessaryModifier Unnecessary modifier 'public' on method 'match': the method is declared in an interface type 106
UnnecessaryModifier Unnecessary modifier 'public' on method 'all': the method is declared in an interface type 113
UnnecessaryModifier Unnecessary modifier 'public' on method 'jsonPath': the method is declared in an interface type 121
UnnecessaryModifier Unnecessary modifier 'public' on method 'select': the method is declared in an interface type 129
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type 137
UnnecessaryModifier Unnecessary modifier 'public' on method 'nodes': the method is declared in an interface type 143

webmagic-core - us/codecraft/webmagic/selector/Selector.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'select': the method is declared in an interface type 20
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type 28

webmagic-core - us/codecraft/webmagic/selector/SmartContentSelector.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 5561
CollapsibleIfStatements This if statement could be combined with its parent 6468

webmagic-core - us/codecraft/webmagic/thread/CountableThreadPool.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 6263

webmagic-extension - us/codecraft/webmagic/MultiPageModel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPageKey': the method is declared in an interface type 21
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPage': the method is declared in an interface type 28
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOtherPages': the method is declared in an interface type 36
UnnecessaryModifier Unnecessary modifier 'public' on method 'combine': the method is declared in an interface type 44

webmagic-extension - us/codecraft/webmagic/handler/RequestMatcher.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'match': the method is declared in an interface type 19
UnnecessaryModifier Unnecessary modifier 'public' on enum 'MatchOther': the enum is declared in an interface type 21

webmagic-extension - us/codecraft/webmagic/handler/SubPageProcessor.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'processPage': the method is declared in an interface type 17

webmagic-extension - us/codecraft/webmagic/handler/SubPipeline.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'processResult': the method is declared in an interface type 19

webmagic-extension - us/codecraft/webmagic/model/AfterExtractor.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'afterProcess': the method is declared in an interface type 13

webmagic-extension - us/codecraft/webmagic/model/HasKey.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'key': the method is declared in an interface type 19

webmagic-extension - us/codecraft/webmagic/model/OOSpider.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'pageModelPipeline'. 47

webmagic-extension - us/codecraft/webmagic/model/PageMapper.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'clazz'. 13

webmagic-extension - us/codecraft/webmagic/model/annotation/ComboExtract.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Op': the enum is declared in an annotation type 24
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Op': nested enums are implicitly static 24
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Source': the enum is declared in an annotation type 55
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Source': nested enums are implicitly static 55

webmagic-extension - us/codecraft/webmagic/model/annotation/ExtractBy.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Type': the enum is declared in an annotation type 27
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 27
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Source': the enum is declared in an annotation type 47
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Source': nested enums are implicitly static 47

webmagic-extension - us/codecraft/webmagic/model/sources/Source.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getText': the method is declared in an interface type 9
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTextList': the method is declared in an interface type 10
UnnecessaryModifier Unnecessary modifier 'public' on class 'RawHtml': the class is declared in an interface type 12
UnnecessaryModifier Unnecessary modifier 'public' on class 'SelectedHtml': the class is declared in an interface type 22
UnnecessaryModifier Unnecessary modifier 'public' on class 'Url': the class is declared in an interface type 38
UnnecessaryModifier Unnecessary modifier 'public' on class 'RawText': the class is declared in an interface type 48
UnnecessaryModifier Unnecessary modifier 'public' on class 'DefaultSource': the class is declared in an interface type 58

webmagic-extension - us/codecraft/webmagic/monitor/SpiderStatusMXBean.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type 12
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStatus': the method is declared in an interface type 14
UnnecessaryModifier Unnecessary modifier 'public' on method 'getThread': the method is declared in an interface type 16
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTotalPageCount': the method is declared in an interface type 18
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLeftPageCount': the method is declared in an interface type 20
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSuccessPageCount': the method is declared in an interface type 22
UnnecessaryModifier Unnecessary modifier 'public' on method 'getErrorPageCount': the method is declared in an interface type 24
UnnecessaryModifier Unnecessary modifier 'public' on method 'getErrorPages': the method is declared in an interface type 26
UnnecessaryModifier Unnecessary modifier 'public' on method 'start': the method is declared in an interface type 28
UnnecessaryModifier Unnecessary modifier 'public' on method 'stop': the method is declared in an interface type 30
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStartTime': the method is declared in an interface type 32
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPagePerSecond': the method is declared in an interface type 34

webmagic-extension - us/codecraft/webmagic/pipeline/PageModelPipeline.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'process': the method is declared in an interface type 13

webmagic-samples - us/codecraft/webmagic/model/samples/Blog.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTitle': the method is declared in an interface type 10
UnnecessaryModifier Unnecessary modifier 'public' on method 'getContent': the method is declared in an interface type 12

webmagic-samples - us/codecraft/webmagic/model/samples/JokejiModel.java

Rule Violation Line
AvoidUsingHardCodedIP Do not hard code the IP address ${variableName} 28

webmagic-samples - us/codecraft/webmagic/samples/AngularJSProcessor.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'ARITICALE_URL'. 20

webmagic-samples - us/codecraft/webmagic/samples/pipeline/OneFilePipeline.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 18

webmagic-samples - us/codecraft/webmagic/samples/scheduler/DelayQueueScheduler.java

Rule Violation Line
UnusedPrivateMethod Avoid unused private methods such as 'getStartTime()'. 36
PrimitiveWrapperInstantiation Do not use `new Long(...)`, prefer `Long.valueOf(...)` 52

webmagic-selenium - us/codecraft/webmagic/downloader/selenium/SeleniumDownloader.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'DRIVER_PHANTOMJS'. 40

webmagic-selenium - us/codecraft/webmagic/downloader/selenium/WebDriverPool.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'mAutoQuitDriver'. 49

Priority 4

webmagic-core - us/codecraft/webmagic/Spider.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'values' is already in scope 696

webmagic-core - us/codecraft/webmagic/selector/PlainText.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'PlainText': 'create' is already in scope 54

webmagic-extension - us/codecraft/webmagic/downloader/PhantomJSDownloader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'PhantomJSDownloader': 'crawlJsPath' is already in scope because it is declared in an enclosing type 81

webmagic-extension - us/codecraft/webmagic/example/OschinaBlog.java

Rule Violation Line
UnnecessaryImport Unused import 'us.codecraft.webmagic.model.annotation.Formatter' 6

webmagic-extension - us/codecraft/webmagic/model/PageModelExtractor.java

Rule Violation Line
UnnecessaryImport Unused import 'us.codecraft.webmagic.model.sources.Source.*' 14

webmagic-extension - us/codecraft/webmagic/scheduler/RedisScheduler.java

Rule Violation Line
UselessParentheses Useless parentheses. 63

webmagic-samples - us/codecraft/webmagic/recover/MmapQueueScheduler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MmapQueueScheduler': 'DATABASE_NAME' is already in scope because it is declared in an enclosing type 44

Files

webmagic-core - us/codecraft/webmagic/Spider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Status(int)': enum constructors are implicitly private 3 685
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'values' is already in scope 4 696

webmagic-core - us/codecraft/webmagic/Task.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getUUID': the method is declared in an interface type 3 18
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSite': the method is declared in an interface type 3 25

webmagic-core - us/codecraft/webmagic/downloader/Downloader.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'download': the method is declared in an interface type 3 24
UnnecessaryModifier Unnecessary modifier 'public' on method 'setThread': the method is declared in an interface type 3 30

webmagic-core - us/codecraft/webmagic/downloader/HttpUriRequestConverter.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'site'. 3 41

webmagic-core - us/codecraft/webmagic/pipeline/CollectorPipeline.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getCollected': the method is declared in an interface type 3 19

webmagic-core - us/codecraft/webmagic/pipeline/Pipeline.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'process': the method is declared in an interface type 3 23

webmagic-core - us/codecraft/webmagic/scheduler/MonitorableScheduler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLeftRequestsCount': the method is declared in an interface type 3 13
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTotalRequestsCount': the method is declared in an interface type 3 15

webmagic-core - us/codecraft/webmagic/scheduler/Scheduler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'push': the method is declared in an interface type 3 23
UnnecessaryModifier Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type 3 31

webmagic-core - us/codecraft/webmagic/scheduler/component/DuplicateRemover.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'isDuplicate': the method is declared in an interface type 3 20
UnnecessaryModifier Unnecessary modifier 'public' on method 'resetDuplicateCheck': the method is declared in an interface type 3 26
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTotalRequestsCount': the method is declared in an interface type 3 33

webmagic-core - us/codecraft/webmagic/selector/ElementSelector.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'select': the method is declared in an interface type 3 22
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type 3 30

webmagic-core - us/codecraft/webmagic/selector/PlainText.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'PlainText': 'create' is already in scope 4 54

webmagic-core - us/codecraft/webmagic/selector/Selectable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'xpath': the method is declared in an interface type 3 19
UnnecessaryModifier Unnecessary modifier 'public' on method '$': the method is declared in an interface type 3 27
UnnecessaryModifier Unnecessary modifier 'public' on method '$': the method is declared in an interface type 3 36
UnnecessaryModifier Unnecessary modifier 'public' on method 'css': the method is declared in an interface type 3 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'css': the method is declared in an interface type 3 53
UnnecessaryModifier Unnecessary modifier 'public' on method 'links': the method is declared in an interface type 3 59
UnnecessaryModifier Unnecessary modifier 'public' on method 'regex': the method is declared in an interface type 3 67
UnnecessaryModifier Unnecessary modifier 'public' on method 'regex': the method is declared in an interface type 3 76
UnnecessaryModifier Unnecessary modifier 'public' on method 'replace': the method is declared in an interface type 3 85
UnnecessaryModifier Unnecessary modifier 'public' on method 'toString': the method is declared in an interface type 3 92
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 3 99
UnnecessaryModifier Unnecessary modifier 'public' on method 'match': the method is declared in an interface type 3 106
UnnecessaryModifier Unnecessary modifier 'public' on method 'all': the method is declared in an interface type 3 113
UnnecessaryModifier Unnecessary modifier 'public' on method 'jsonPath': the method is declared in an interface type 3 121
UnnecessaryModifier Unnecessary modifier 'public' on method 'select': the method is declared in an interface type 3 129
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type 3 137
UnnecessaryModifier Unnecessary modifier 'public' on method 'nodes': the method is declared in an interface type 3 143

webmagic-core - us/codecraft/webmagic/selector/Selector.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'select': the method is declared in an interface type 3 20
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type 3 28

webmagic-core - us/codecraft/webmagic/selector/SmartContentSelector.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 5561
CollapsibleIfStatements This if statement could be combined with its parent 3 6468

webmagic-core - us/codecraft/webmagic/thread/CountableThreadPool.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 6263

webmagic-extension - us/codecraft/webmagic/MultiPageModel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPageKey': the method is declared in an interface type 3 21
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPage': the method is declared in an interface type 3 28
UnnecessaryModifier Unnecessary modifier 'public' on method 'getOtherPages': the method is declared in an interface type 3 36
UnnecessaryModifier Unnecessary modifier 'public' on method 'combine': the method is declared in an interface type 3 44

webmagic-extension - us/codecraft/webmagic/downloader/PhantomJSDownloader.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'PhantomJSDownloader': 'crawlJsPath' is already in scope because it is declared in an enclosing type 4 81

webmagic-extension - us/codecraft/webmagic/example/OschinaBlog.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'us.codecraft.webmagic.model.annotation.Formatter' 4 6

webmagic-extension - us/codecraft/webmagic/handler/RequestMatcher.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'match': the method is declared in an interface type 3 19
UnnecessaryModifier Unnecessary modifier 'public' on enum 'MatchOther': the enum is declared in an interface type 3 21

webmagic-extension - us/codecraft/webmagic/handler/SubPageProcessor.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'processPage': the method is declared in an interface type 3 17

webmagic-extension - us/codecraft/webmagic/handler/SubPipeline.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'processResult': the method is declared in an interface type 3 19

webmagic-extension - us/codecraft/webmagic/model/AfterExtractor.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'afterProcess': the method is declared in an interface type 3 13

webmagic-extension - us/codecraft/webmagic/model/HasKey.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'key': the method is declared in an interface type 3 19

webmagic-extension - us/codecraft/webmagic/model/OOSpider.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'pageModelPipeline'. 3 47

webmagic-extension - us/codecraft/webmagic/model/PageMapper.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'clazz'. 3 13

webmagic-extension - us/codecraft/webmagic/model/PageModelExtractor.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'us.codecraft.webmagic.model.sources.Source.*' 4 14

webmagic-extension - us/codecraft/webmagic/model/annotation/ComboExtract.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Op': the enum is declared in an annotation type 3 24
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Op': nested enums are implicitly static 3 24
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Source': the enum is declared in an annotation type 3 55
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Source': nested enums are implicitly static 3 55

webmagic-extension - us/codecraft/webmagic/model/annotation/ExtractBy.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Type': the enum is declared in an annotation type 3 27
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Type': nested enums are implicitly static 3 27
UnnecessaryModifier Unnecessary modifier 'public' on enum 'Source': the enum is declared in an annotation type 3 47
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Source': nested enums are implicitly static 3 47

webmagic-extension - us/codecraft/webmagic/model/sources/Source.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getText': the method is declared in an interface type 3 9
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTextList': the method is declared in an interface type 3 10
UnnecessaryModifier Unnecessary modifier 'public' on class 'RawHtml': the class is declared in an interface type 3 12
UnnecessaryModifier Unnecessary modifier 'public' on class 'SelectedHtml': the class is declared in an interface type 3 22
UnnecessaryModifier Unnecessary modifier 'public' on class 'Url': the class is declared in an interface type 3 38
UnnecessaryModifier Unnecessary modifier 'public' on class 'RawText': the class is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifier 'public' on class 'DefaultSource': the class is declared in an interface type 3 58

webmagic-extension - us/codecraft/webmagic/monitor/SpiderStatusMXBean.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type 3 12
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStatus': the method is declared in an interface type 3 14
UnnecessaryModifier Unnecessary modifier 'public' on method 'getThread': the method is declared in an interface type 3 16
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTotalPageCount': the method is declared in an interface type 3 18
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLeftPageCount': the method is declared in an interface type 3 20
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSuccessPageCount': the method is declared in an interface type 3 22
UnnecessaryModifier Unnecessary modifier 'public' on method 'getErrorPageCount': the method is declared in an interface type 3 24
UnnecessaryModifier Unnecessary modifier 'public' on method 'getErrorPages': the method is declared in an interface type 3 26
UnnecessaryModifier Unnecessary modifier 'public' on method 'start': the method is declared in an interface type 3 28
UnnecessaryModifier Unnecessary modifier 'public' on method 'stop': the method is declared in an interface type 3 30
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStartTime': the method is declared in an interface type 3 32
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPagePerSecond': the method is declared in an interface type 3 34

webmagic-extension - us/codecraft/webmagic/pipeline/PageModelPipeline.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'process': the method is declared in an interface type 3 13

webmagic-extension - us/codecraft/webmagic/scheduler/RedisScheduler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 63

webmagic-samples - us/codecraft/webmagic/model/samples/Blog.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTitle': the method is declared in an interface type 3 10
UnnecessaryModifier Unnecessary modifier 'public' on method 'getContent': the method is declared in an interface type 3 12

webmagic-samples - us/codecraft/webmagic/model/samples/JokejiModel.java

Rule Violation Priority Line
AvoidUsingHardCodedIP Do not hard code the IP address ${variableName} 3 28

webmagic-samples - us/codecraft/webmagic/recover/MmapQueueScheduler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MmapQueueScheduler': 'DATABASE_NAME' is already in scope because it is declared in an enclosing type 4 44

webmagic-samples - us/codecraft/webmagic/samples/AngularJSProcessor.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'ARITICALE_URL'. 3 20

webmagic-samples - us/codecraft/webmagic/samples/pipeline/OneFilePipeline.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 3 18

webmagic-samples - us/codecraft/webmagic/samples/scheduler/DelayQueueScheduler.java

Rule Violation Priority Line
UnusedPrivateMethod Avoid unused private methods such as 'getStartTime()'. 3 36
PrimitiveWrapperInstantiation Do not use `new Long(...)`, prefer `Long.valueOf(...)` 3 52

webmagic-selenium - us/codecraft/webmagic/downloader/selenium/SeleniumDownloader.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'DRIVER_PHANTOMJS'. 3 40

webmagic-selenium - us/codecraft/webmagic/downloader/selenium/WebDriverPool.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'mAutoQuitDriver'. 3 49