PMD Results
The following document contains the results of PMD 7.0.0.
Violations By Priority
Priority 3
us/codecraft/webmagic/Spider.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'Status(int)': enum constructors are implicitly private |
685 |
us/codecraft/webmagic/Task.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getUUID': the method is declared in an interface type |
18 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getSite': the method is declared in an interface type |
25 |
us/codecraft/webmagic/downloader/Downloader.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'download': the method is declared in an interface type |
24 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'setThread': the method is declared in an interface type |
30 |
us/codecraft/webmagic/downloader/HttpUriRequestConverter.java
us/codecraft/webmagic/pipeline/CollectorPipeline.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getCollected': the method is declared in an interface type |
19 |
us/codecraft/webmagic/pipeline/Pipeline.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'process': the method is declared in an interface type |
23 |
us/codecraft/webmagic/scheduler/MonitorableScheduler.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getLeftRequestsCount': the method is declared in an interface type |
13 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getTotalRequestsCount': the method is declared in an interface type |
15 |
us/codecraft/webmagic/scheduler/Scheduler.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'push': the method is declared in an interface type |
23 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type |
31 |
us/codecraft/webmagic/scheduler/component/DuplicateRemover.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'isDuplicate': the method is declared in an interface type |
20 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'resetDuplicateCheck': the method is declared in an interface type |
26 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getTotalRequestsCount': the method is declared in an interface type |
33 |
us/codecraft/webmagic/selector/ElementSelector.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'select': the method is declared in an interface type |
22 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type |
30 |
us/codecraft/webmagic/selector/Selectable.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'xpath': the method is declared in an interface type |
19 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method '$': the method is declared in an interface type |
27 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method '$': the method is declared in an interface type |
36 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'css': the method is declared in an interface type |
44 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'css': the method is declared in an interface type |
53 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'links': the method is declared in an interface type |
59 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'regex': the method is declared in an interface type |
67 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'regex': the method is declared in an interface type |
76 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'replace': the method is declared in an interface type |
85 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'toString': the method is declared in an interface type |
92 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'get': the method is declared in an interface type |
99 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'match': the method is declared in an interface type |
106 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'all': the method is declared in an interface type |
113 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'jsonPath': the method is declared in an interface type |
121 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'select': the method is declared in an interface type |
129 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type |
137 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'nodes': the method is declared in an interface type |
143 |
us/codecraft/webmagic/selector/Selector.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'select': the method is declared in an interface type |
20 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type |
28 |
us/codecraft/webmagic/selector/SmartContentSelector.java
us/codecraft/webmagic/thread/CountableThreadPool.java
Priority 4
us/codecraft/webmagic/Spider.java
us/codecraft/webmagic/selector/PlainText.java
Files
us/codecraft/webmagic/Spider.java
us/codecraft/webmagic/Task.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getUUID': the method is declared in an interface type |
3 |
18 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getSite': the method is declared in an interface type |
3 |
25 |
us/codecraft/webmagic/downloader/Downloader.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'download': the method is declared in an interface type |
3 |
24 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'setThread': the method is declared in an interface type |
3 |
30 |
us/codecraft/webmagic/downloader/HttpUriRequestConverter.java
us/codecraft/webmagic/pipeline/CollectorPipeline.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getCollected': the method is declared in an interface type |
3 |
19 |
us/codecraft/webmagic/pipeline/Pipeline.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'process': the method is declared in an interface type |
3 |
23 |
us/codecraft/webmagic/scheduler/MonitorableScheduler.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getLeftRequestsCount': the method is declared in an interface type |
3 |
13 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getTotalRequestsCount': the method is declared in an interface type |
3 |
15 |
us/codecraft/webmagic/scheduler/Scheduler.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'push': the method is declared in an interface type |
3 |
23 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type |
3 |
31 |
us/codecraft/webmagic/scheduler/component/DuplicateRemover.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'isDuplicate': the method is declared in an interface type |
3 |
20 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'resetDuplicateCheck': the method is declared in an interface type |
3 |
26 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getTotalRequestsCount': the method is declared in an interface type |
3 |
33 |
us/codecraft/webmagic/selector/ElementSelector.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'select': the method is declared in an interface type |
3 |
22 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type |
3 |
30 |
us/codecraft/webmagic/selector/PlainText.java
us/codecraft/webmagic/selector/Selectable.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'xpath': the method is declared in an interface type |
3 |
19 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method '$': the method is declared in an interface type |
3 |
27 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method '$': the method is declared in an interface type |
3 |
36 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'css': the method is declared in an interface type |
3 |
44 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'css': the method is declared in an interface type |
3 |
53 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'links': the method is declared in an interface type |
3 |
59 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'regex': the method is declared in an interface type |
3 |
67 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'regex': the method is declared in an interface type |
3 |
76 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'replace': the method is declared in an interface type |
3 |
85 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'toString': the method is declared in an interface type |
3 |
92 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'get': the method is declared in an interface type |
3 |
99 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'match': the method is declared in an interface type |
3 |
106 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'all': the method is declared in an interface type |
3 |
113 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'jsonPath': the method is declared in an interface type |
3 |
121 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'select': the method is declared in an interface type |
3 |
129 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type |
3 |
137 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'nodes': the method is declared in an interface type |
3 |
143 |
us/codecraft/webmagic/selector/Selector.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'select': the method is declared in an interface type |
3 |
20 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'selectList': the method is declared in an interface type |
3 |
28 |
us/codecraft/webmagic/selector/SmartContentSelector.java
us/codecraft/webmagic/thread/CountableThreadPool.java